Merge lp://qastaging/~mhr3/unity/fix-965492 into lp://qastaging/unity
Proposed by
Michal Hruby
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Gord Allott | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 2219 | ||||
| Proposed branch: | lp://qastaging/~mhr3/unity/fix-965492 | ||||
| Merge into: | lp://qastaging/unity | ||||
| Diff against target: |
182 lines (+52/-7) 5 files modified
plugins/unityshell/src/DashView.cpp (+8/-1) plugins/unityshell/src/LensView.cpp (+14/-5) plugins/unityshell/src/LensView.h (+5/-1) plugins/unityshell/src/SearchBar.cpp (+24/-0) plugins/unityshell/src/SearchBar.h (+1/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~mhr3/unity/fix-965492 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gord Allott (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Ensure that the spinner is shown even for empty searches
Description of the change
The initial display of the home lens can take some time and during this time the user has no feedback that there's something going on inside the dash.
Whenever we display the dash, the Search() method of lenses is called, so we're properly notified when the search finishes (libunity makes sure of that). This allows us to display the spinner meanwhile, and user knows there's some activity going on.
Because of the timing nature of the change, there are no new tests, but at least existing tests still pass.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1 from me