Merge lp://qastaging/~mhr3/unity/fix-971430 into lp://qastaging/unity
Proposed by
Michal Hruby
| Status: | Merged |
|---|---|
| Approved by: | Gord Allott |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2211 |
| Proposed branch: | lp://qastaging/~mhr3/unity/fix-971430 |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
43 lines (+22/-0) 2 files modified
manual-tests/Dash.txt (+17/-0) plugins/unityshell/src/LensView.cpp (+5/-0) |
| To merge this branch: | bzr merge lp://qastaging/~mhr3/unity/fix-971430 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gord Allott (community) | Approve | ||
| Brandon Schaefer (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Make sure we don't display the no-results-hint if we do have results
Description of the change
In some rare cases, it's possible that a lens view in unity shows both the no-results-hint text while displaying some results. This can happen in cases when lens updates the results itself without unity invoking its (Global)Search method.
Make sure the no-results-hint is hidden when new results are added to the view.
Added manual test for this special case (there already is an AP test for the standard case).
To post a comment you must log in.
Revision history for this message
| Gord Allott (gordallott) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1 Looks good, and confirmed fixed on my machine.