Merge lp://qastaging/~mhr3/zeitgeist-extensions/scheme-detection into lp://qastaging/zeitgeist-extensions

Proposed by Michal Hruby
Status: Merged
Approved by: Mikkel Kamstrup Erlandsen
Approved revision: 77
Merged at revision: 75
Proposed branch: lp://qastaging/~mhr3/zeitgeist-extensions/scheme-detection
Merge into: lp://qastaging/zeitgeist-extensions
Diff against target: 85 lines (+17/-22)
1 file modified
fts/fts.py (+17/-22)
To merge this branch: bzr merge lp://qastaging/~mhr3/zeitgeist-extensions/scheme-detection
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen Approve
Review via email: mp+77481@code.qastaging.launchpad.net
To post a comment you must log in.
76. By Michal Hruby

Get rid of unnecessary branches in the check_index_and_start_worker method

77. By Michal Hruby

Try to prevent some races

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Ok. The code looks good. I tested the hell out of this with log in/out cycles. Deleting random parts of the Xapian index, and calling ForceReindex() over DBus while concurrently doing searches. Everything was rock solid.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: