Snapcraft

Merge lp://qastaging/~michael.nelson/snapcraft/fix-golang-tutorial-to-match-changes-from-r132 into lp://qastaging/~snappy-dev/snapcraft/core

fix-golang-tutorial-to-match-changes-from-r132
Merge into core

Proposed by Michael Nelson on 2015-09-04

Status:	Merged
Approved by:	Sergio Schvezov on 2015-09-07
Approved revision:	153
Merged at revision:	151
Proposed branch:	lp://qastaging/~michael.nelson/snapcraft/fix-golang-tutorial-to-match-changes-from-r132
Merge into:	lp://qastaging/~snappy-dev/snapcraft/core
Diff against target:	95 lines (+18/-23) 1 file modified docs/your-first-snap.md (+18/-23)
To merge this branch:	bzr merge lp://qastaging/~michael.nelson/snapcraft/fix-golang-tutorial-to-match-changes-from-r132
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Sergio Schvezov		2015-09-04	Approve on 2015-09-07
Review via email: mp+270131@code.qastaging.launchpad.net

Commit message

Fix snapcraft.yaml's reference to go-package plugin to match changes in r132.

Description of the change

Without this, following the tutorial results in:

$ snapcraft stage
Unknown plugin: go1.4-project
Could not load part go1.4-project

Currently, if you try to add a:

snappy-metadata: meta

to your snapcraft.yaml, you'll see an error [1]. Turns out the metadata is now expected in the snapcraft.yaml itself, so README updated to match that after testing locally.

[1] http://paste.ubuntu.com/12270254/

lp://qastaging/~michael.nelson/snapcraft/fix-golang-tutorial-to-match-changes-from-r132 updated on 2015-09-04

152. By Michael Nelson on 2015-09-04: Update your-first-snap now that metadata is in the snapcraft.yaml file itself.

Revision history for this message

Sergio Schvezov (sergiusens) wrote on 2015-09-07:

it all looks good, thanks, just maybe pick a different a icon?

lp://qastaging/~michael.nelson/snapcraft/fix-golang-tutorial-to-match-changes-from-r132 updated on 2015-09-07

153. By Michael Nelson on 2015-09-07: Switch example icon to text-x-apport.png

Revision history for this message

Michael Nelson (michael.nelson) wrote on 2015-09-07:

On Mon, Sep 7, 2015 at 11:21 PM Sergio Schvezov <
<email address hidden>> wrote:

> it all looks good, thanks, just maybe pick a different a icon?
>
> Diff comments:
>
> > === modified file 'docs/your-first-snap.md'
> > --- docs/your-first-snap.md 2015-08-05 13:38:39 +0000
> > +++ docs/your-first-snap.md 2015-09-04 03:24:38 +0000
> > @@ -213,9 +205,12 @@
> > plugin: copy
> > files:
> > webcam-webui: bin/webcam-webui
> > - snappy-metadata: meta
> > -
> > -And tell Snapcraft to actually make the snap package:
> > +
> > +Copy a png icon of your choice into your current directory:
> > +
> > + $ cp /usr/share/icons/hicolor/256x256/apps/unity-datetime-panel.png
> ./icon.png
>
> how about a different icon?
>
>
Done. It's just an example to run the demo (as the icon is now required),
but I've switch it
to /usr/share/icons/hicolor/64/mimetypes/text-x-apport.png