Thumbnailer

Merge lp://qastaging/~michihenning/thumbnailer/gstreamer-plugins into lp://qastaging/thumbnailer/devel

gstreamer-plugins
Merge into devel

Proposed by Michi Henning on 2017-02-03

Status:	Merged
Approved by:	James Henstridge on 2017-02-08
Approved revision:	379
Merged at revision:	371
Proposed branch:	lp://qastaging/~michihenning/thumbnailer/gstreamer-plugins
Merge into:	lp://qastaging/thumbnailer/devel
Prerequisite:	lp://qastaging/~michihenning/thumbnailer/snap
Diff against target:	257 lines (+106/-66) 6 files modified CMakeLists.txt (+2/-2) include/internal/env_vars.h (+2/-0) snapcraft.yaml (+13/-1) src/env_vars.cpp (+23/-0) src/thumbnailer-admin/CMakeLists.txt (+0/-2) src/vs-thumb/vs-thumb.cpp (+66/-61)
To merge this branch:	bzr merge lp://qastaging/~michihenning/thumbnailer/gstreamer-plugins
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
James Henstridge		2017-02-03	Approve on 2017-02-08
unity-api-1-bot	continuous-integration		Approve on 2017-02-08
Review via email: mp+316309@code.qastaging.launchpad.net

Commit message

Added gstreamer plugin dependencies.

Description of the change

Added gstreamer plugin dependencies.

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2017-02-03:

PASSED: Continuous integration, rev:372
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-ci/27/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1594
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1601
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1379
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1379/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1379
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1379/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1379
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1379/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1379
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1379/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1379
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1379/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1379
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1379/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-ci/27/rebuild

review: Approve (continuous-integration)

Revision history for this message

James Henstridge (jamesh) wrote on 2017-02-07:

I don't think the GST_PLUGIN_PATH manipulation should be done here: instead, it probably belongs in the desktop-ubuntu-app-platform part.

In particular, I don't think we want to ignore the GStreamer plugins from ubuntu-app-platform: instead, GST_PLUGIN_PATH should be set to take plugins from our snap, and then ubuntu-app-platform second. That way we probably only need to ship libgstlibav.so, rather than an entire suite of elements.

review: Needs Fixing

Revision history for this message

Michi Henning (michihenning) wrote on 2017-02-07:

> I don't think the GST_PLUGIN_PATH manipulation should be done here: instead,
> it probably belongs in the desktop-ubuntu-app-platform part.

I can raise a bug for that, but I'm not sure I agree. ubuntu-app-platform can't really know where a snap chooses to install additional plugins; they could be in a different path.

> In particular, I don't think we want to ignore the GStreamer plugins from
> ubuntu-app-platform: instead, GST_PLUGIN_PATH should be set to take plugins
> from our snap, and then ubuntu-app-platform second. That way we probably only
> need to ship libgstlibav.so, rather than an entire suite of elements.

We are not ignoring them. desktop-launch sets GST_PLUGIN_SYSTEM_PATH, and vs-thumb sets GST_PLUGIN_PATH. According to the gstreamer doc, it first loads anything in GST_PLUGIN_PATH, and then anything in GST_PLUGIN_SYSTEM_PATH. (If we were ignoring the libs in ubuntu-app-platform, it wouldn't work at all, but .ogg video extraction definitely works.)

None of the libraries in the explicit list are in ubuntu-app-platform. They are basically all dependencies of gstreamer when it uses the codecs in libav.

I can't for the life of me figure out at the moment why .mp4 won't work. I keep getting "Your GStreamer installation is missing a plug-in."

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2017-02-08:

PASSED: Continuous integration, rev:375
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-ci/28/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1637
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1644
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1420
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1420/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1420
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1420/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1420
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1420/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1420
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1420/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1420
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1420/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1420
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1420/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-ci/28/rebuild

review: Approve (continuous-integration)

lp://qastaging/~michihenning/thumbnailer/gstreamer-plugins updated on 2017-02-08

376. By Michi Henning on 2017-02-08: Using build-packages and explicit copy into the stage area
for libav and libgpm now, so snapcraft works out the run-time
dependencies for us.

Revision history for this message

Michi Henning (michihenning) wrote on 2017-02-08:

Works on xenial and zesty now. squashfs size is 40 MB on xenial, 50 MB on zesty. Looks like we are dragging in loads of stuff still that's also in ubuntu-app-platform though. Just skimming, there are at least:

libogg.so.0, libtag.so.1, libwavpack.so.1, libX11.so.6, libQt5Core.so.5, libQt5DBus.so.5, libQt5Network.so.5, libXau.so.6, etc, etc...

Revision history for this message

unity-api-1-bot (unity-api-1-bot) wrote on 2017-02-08:

PASSED: Continuous integration, rev:376
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-ci/29/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1638
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1645
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1421
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1421/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1421
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1421/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1421
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1421/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1421
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1421/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1421
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1421/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1421
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1421/artifact/output/*zip*/output.zip