Thumbnailer

Merge lp://qastaging/~michihenning/thumbnailer/zesty-test-suppression into lp://qastaging/thumbnailer

  1. zesty-test-suppression
  2. Merge into trunk
Proposed by Michi Henning
Status: Merged
Approved by: Michi Henning
Approved revision: 377
Merged at revision: 153
Proposed branch: lp://qastaging/~michihenning/thumbnailer/zesty-test-suppression
Merge into: lp://qastaging/thumbnailer
Diff against target: 104 lines (+35/-3)
3 files modified
CMakeLists.txt (+1/-3)
debian/changelog (+8/-0)
src/local_album_art.cpp (+26/-0)
To merge this branch: bzr merge lp://qastaging/~michihenning/thumbnailer/zesty-test-suppression
Reviewer Review Type Date Requested Status
Michi Henning (community) Approve
James Henstridge Approve
Review via email: mp+310376@code.qastaging.launchpad.net

Commit message

Added zesty to list of distros for which we suppress Qt-related tests.
Fixed code to work with taglib 1.11, which breaks the behavior of the taglib 1.9 API.

Description of the change

Added zesty to list of distros for which we suppress Qt-related tests.

To post a comment you must log in.
Revision history for this message
James Henstridge (jamesh) wrote :

Looks good, although we'll need to find a real solution soon as we begin to rely more on Xenial.

review: Approve
Revision history for this message
Michi Henning (michihenning) wrote :

Re-approving. The only change since James's approval is the merged changelog and that the builders have reverted back to leveldb 1.18.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: