Unity Media Scanner Scope

Merge lp://qastaging/~michihenning/unity-scope-mediascanner/allow-artist-with-empty-album into lp://qastaging/unity-scope-mediascanner

  1. allow-artist-with-empty-album
  2. Merge into trunk
Proposed by Michi Henning
Status: Merged
Approved by: James Henstridge
Approved revision: 289
Merged at revision: 290
Proposed branch: lp://qastaging/~michihenning/unity-scope-mediascanner/allow-artist-with-empty-album
Merge into: lp://qastaging/unity-scope-mediascanner
Diff against target: 44 lines (+12/-7)
2 files modified
debian/changelog (+7/-0)
src/mymusic/music-scope.cpp (+5/-7)
To merge this branch: bzr merge lp://qastaging/~michihenning/unity-scope-mediascanner/allow-artist-with-empty-album
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
James Henstridge Approve
Review via email: mp+283689@code.qastaging.launchpad.net

Commit message

If we only have empty albums for an artist, still try to get artist image regardless.
7digital allows artist queries with an empty album and still returns results in most cases.

Description of the change

If we only have empty albums for an artist, still try to get artist image regardless.
7digital allows artist queries with an empty album and still returns results in most cases.

To post a comment you must log in.
lp://qastaging/~michihenning/unity-scope-mediascanner/allow-artist-with-empty-album updated
288. By Michi Henning

Updated changelog.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:287
http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-ci/196/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-amd64-ci/30
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-armhf-ci/30
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-i386-ci/30
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-armhf-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-i386-ci/23

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-mediascanner-ci/196/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:288
http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-ci/197/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-amd64-ci/31
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-armhf-ci/31
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-i386-ci/31
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-amd64-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-armhf-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-i386-ci/24

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-mediascanner-ci/197/rebuild

review: Approve (continuous-integration)
Revision history for this message
James Henstridge (jamesh) wrote :

Thanks for finding this. When the dash.ubuntu.com artist-art service was added, you definitely needed an album for a successful lookup. This code never got updated when the restriction was removed.

I've left an inline comment about a way to simplify the logic a bit.

lp://qastaging/~michihenning/unity-scope-mediascanner/allow-artist-with-empty-album updated
289. By Michi Henning

Re-arranged loop variables.

Revision history for this message
James Henstridge (jamesh) wrote :

Looks good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:290
http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-ci/198/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-amd64-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-armhf-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-i386-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-amd64-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-armhf-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-i386-ci/25

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-mediascanner-ci/198/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michi Henning (michihenning) wrote :

I've re-tested this with silo 16 after adding it back. Works as expected. (I'm not sure why I thought it didn't work on Friday. Most likely, I didn't pull the correct silo for testing.)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: