Merge lp://qastaging/~midori/midori/availactions into lp://qastaging/midori

Proposed by Cris Dywan
Status: Work in progress
Proposed branch: lp://qastaging/~midori/midori/availactions
Merge into: lp://qastaging/midori
Diff against target: 54 lines (+19/-0)
2 files modified
midori/midori-browser.c (+16/-0)
midori/midori-settings.vala (+3/-0)
To merge this branch: bzr merge lp://qastaging/~midori/midori/availactions
Reviewer Review Type Date Requested Status
Midori Devs Pending
Review via email: mp+165271@code.qastaging.launchpad.net

Description of the change

Implement available-actions whitelist

midori -c /tmp/kiosktest -e available-actions=SaveAs,Fullscreen,TabNew,Cut,Navigationbar

To post a comment you must log in.
6174. By Cris Dywan

Fix different action entry lists inside loops

Revision history for this message
Cory J. Geesaman (cory-g) wrote :

Christian,
Thanks for the update, but there are still some items that are visible with the flag -e available-actions=none:

Back
Forward
Stop
Refresh
Inspect Element
Undo Close Tab
Open in New Window
Add Bookmark

The Back/Forward/Stop/Refresh buttons should go since they can control the flow of an application (it would be nice if the shortcuts extension could disable F5/Refresh but that one isn't so bad), Inspect Element/Undo Close Tab/Open in New Window/Add Bookmark can definitely be used to circumvent a kiosk setup.

With ctrl+right-click the items visible are:

Undo Close Tab
Open in New Window
Add Bookmark
Inspect Element

Like you said, the ctrl+right-click one looks a bit better, but the command doesn't remove all the menu items.

Unmerged revisions

6174. By Cris Dywan

Fix different action entry lists inside loops

6173. By Cris Dywan

Implement available-actions whitelist

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: