Merge lp://qastaging/~midori/midori/headerBarSupport into lp://qastaging/midori

Packing the urlbar into the title are looks weird and means autocompletion results just aren't legible. I think it would make more sense to just pack it left and expand like you'd do in a regular toolbar.

Since the "Toolbar Editor" extension exposes itself through right clicking on the toolbar, there's now no way to use this extension. It should probably get a little settings icon like other extensions with settings have

I'm not sure if I understand the comments fully - I changed the property used to size the URL entry so it expands fully. Is that what you meant by packing?

Right-click on buttons works perfectly for me, like with the classic toolbar, you get the menu to toggle toolbars and the toolbar editor is the last item in it.

URL bar looks right here now :)

Can you possibly add a 1px top and bottom margin to the url entry? It looks like without that box-shadow is clipped.

Ah, if you right click the items themselves you'll get the menu. But if you click the headerbar itself, you only get the window menu. I guess I can file this separately. I personally think it's a little counter-intuitive.

I'm not sure how much you care about the separate web search these days. I added it just for kicks and it's really tiny. Also, there's no pane handle to resize like there used to be.

Hey Christian, the last revision didn't seem to fix the issue. The space needs to be reserved for the entry itself. So instead of headerbar.custom_title, you would need to use (widget as Gtk.Entry) directly.

Right-click to edit has always been on the buttons themselves. Also it's not officially possible to extend the headerbar context menu - so I'd say that should be discussed and dealt with separately.

Regarding resizing of web search: I'm not sure if it's worth porting the existing design as-is because it can only work if both entries sit in the headerbar which seems conceptually wrong. If interest is there it can certainly be looked into later.

Yeah I'm of the opinion still that the separate web search should just be removed since that functionality is already provided in the urlbar. Just wanted to test possible cases :)

I agree the right click menu bit can/should be a different issue.

Crashes when enabling "statusbar features" extension:

ERROR:/home/daniel/Projects/headerBarSupport/extensions/statusbar-features.c:59:statusbar_features_toolbar_notify_toolbar_style_cb: code should not be reached

Thoughts on moving the extensions area of the toolbar to the right? This would seem to follow with Chrome and Firefox

Everything working as expected here :D

I made some comments throughout the diff about code style inconsistencies

Be sure to update the translation template after you commit new string(s) to trunk