Midori Web Browser

Merge lp://qastaging/~midori/midori/hidpiTabs into lp://qastaging/midori

hidpiTabs
Merge into trunk

Proposed by Cris Dywan on 2015-08-10

Status:

Merged

Approved by:

gue5t gue5t on 2016-02-20

Approved revision:

7019

Merged at revision:

7105

Proposed branch:

lp://qastaging/~midori/midori/hidpiTabs

Merge into:

lp://qastaging/midori

Diff against target:

153 lines (+31/-37)

3 files modified

katze/katze-item.c (+1/-1)
midori/midori-notebook.vala (+16/-2)
midori/midori-view.c (+14/-34)

To merge this branch:

bzr merge lp://qastaging/~midori/midori/hidpiTabs

High

Fix Committed

Link a bug report

Reviewer	Review Type	Date Requested	Status
gue5t gue5t		2015-08-10	Approve on 2016-02-20
Review via email: mp+267467@code.qastaging.launchpad.net

Commit message

Scale tab icons taking scale factor into account

Use GLib.Icon all the way.

lp://qastaging/~midori/midori/hidpiTabs updated on 2015-08-10

7018. By Cris Dywan on 2015-08-10: No need to deal with icon size in _midori_web_view_load_icon

Revision history for this message

gue5t gue5t (gue5t) wrote on 2015-08-11:

Pages like <https://developer.gnome.org/gtk3/unstable/GtkApplication.html> still show a small icon (which makes tabs different sizes) with wk1; locally it looks like changing the "> icon_width" condition to "!= icon_width" (and same for height) is enough to allow upscaling to make sure we get the right size.

Also, the "Tabs" menubar menu as well as bookmarks and history still have blurry icons that we should fix, but I blame Katze infrastructure for that. It might be better to address that stuff in a separate branch.

review: Needs Fixing

lp://qastaging/~midori/midori/hidpiTabs updated on 2016-01-23