Merge lp://qastaging/~midori/midori/mandatoryGcr into lp://qastaging/midori
Proposed by
Cris Dywan
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Danielle Foré | ||||
| Approved revision: | 6903 | ||||
| Merged at revision: | 6903 | ||||
| Proposed branch: | lp://qastaging/~midori/midori/mandatoryGcr | ||||
| Merge into: | lp://qastaging/midori | ||||
| Diff against target: |
145 lines (+18/-22) 3 files modified
CMakeLists.txt (+8/-9) midori/midori-locationaction.c (+5/-6) midori/midori-view.c (+5/-7) |
||||
| To merge this branch: | bzr merge lp://qastaging/~midori/midori/mandatoryGcr | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| gue5t gue5t | Approve | ||
|
Review via email:
|
|||
Commit message
Make GCR mandatory for all builds
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
It compiles and runs with GTK2 and GTK3, and the code changes look sane. Ideally we would implement more UI for GTK2, but mandatory GCR presence is good even without.