Merge lp://qastaging/~midori/midori/navigationAction into lp://qastaging/midori

Proposed by Cris Dywan
Status: Work in progress
Proposed branch: lp://qastaging/~midori/midori/navigationAction
Merge into: lp://qastaging/midori
Diff against target: 953 lines (+326/-419)
5 files modified
midori/midori-browser.c (+29/-416)
midori/midori-navigationaction.vala (+293/-0)
midori/midori-view.c (+3/-0)
midori/midori-window.vala (+0/-3)
po/POTFILES.in (+1/-0)
To merge this branch: bzr merge lp://qastaging/~midori/midori/navigationAction
Reviewer Review Type Date Requested Status
Danielle Foré (community) Needs Fixing
Review via email: mp+257570@code.qastaging.launchpad.net

Commit message

Split Back, Forward and friends into NavigationAction

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

Gtk.Stock is deprecated. Relevant icon names are "go-next", "go-previous", "go-home", "media-skip-forward", "media-skip-backward", "view-refresh"

review: Needs Fixing
6950. By Cris Dywan

Merge lp:midori

6951. By Cris Dywan

Remaining NavigationAction subclasses

6952. By Cris Dywan

Coding style fixes

Revision history for this message
Cris Dywan (kalikiana) wrote :

In 10 minutes I couldn't find a way to use GLib.Icon with ThemedIcon.with_fallbacks so that icons show (at all) and hide as per style, so for now I'll stick to stock icons.

6953. By Cris Dywan

Related page boilerplate in NavigationAction

Revision history for this message
Danielle Foré (danrabbit) wrote :

For what it's worth, Gtk.Action is also deprecated :p The only thing I can really figure out so far is that the button itself is visible but the Gtk.Image packed into it is set visible = false.

Revision history for this message
Cris Dywan (kalikiana) wrote :

The slight predicament is that there's nothing replacing Gtk.Action. We need something with an icon, a short cut, sub menus and a label. We have Midori.ContextAction. But it still inherits from Gtk.Action because otherwise a lot of code would have to be changed for the sake of re-implementing the same functionality without existing API... and trying to get away from that you hit these very stupid time sink bugs where GTK+ doesn't work the same way if you use gicon, historical bugs never fixed in Gtk.Action and code that wasn't tested because, well, GNOME default apps are never used with non-recent GTK+ releases.

That said, what I would like to see is icon names on ContextAction that automatically append -symbolic, alternate icon names and an accelerators property (plural). I did the midori_browser_add_action method as a step towards that, but I just don't see it happening in one branch.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Hrm accoring to valadoc, GLib.Action replaces it http://valadoc.org/#!api=gio-2.0/GLib.Action

Unmerged revisions

6953. By Cris Dywan

Related page boilerplate in NavigationAction

6952. By Cris Dywan

Coding style fixes

6951. By Cris Dywan

Remaining NavigationAction subclasses

6950. By Cris Dywan

Merge lp:midori

6949. By Cris Dywan

Split Back, Forward and friends into NavigationAction

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: