Merge lp://qastaging/~midori/midori/noSessionOnStartup into lp://qastaging/midori

Proposed by Cris Dywan
Status: Merged
Approved by: Cris Dywan
Approved revision: 6485
Merged at revision: 6486
Proposed branch: lp://qastaging/~midori/midori/noSessionOnStartup
Merge into: lp://qastaging/midori
Diff against target: 81 lines (+32/-7)
2 files modified
extensions/delayed-load.vala (+0/-3)
extensions/tabby.vala (+32/-4)
To merge this branch: bzr merge lp://qastaging/~midori/midori/noSessionOnStartup
Reviewer Review Type Date Requested Status
Cris Dywan Approve
André Stösel Approve
Review via email: mp+195482@code.qastaging.launchpad.net

Commit message

Open speed dial or homepage according to preference

To post a comment you must log in.
Revision history for this message
gue5t gue5t (gue5t) wrote :

Tested without regressions, but it seems that if the startup preference is Speed Dial or Homepage, then a new session is added to the tabby db file without removing the old ones.

6485. By André Stösel

check MidoriStartup before delaying pages

Revision history for this message
André Stösel (ivaldi) wrote :

Maybe we should use Midori.MidoriStartup.DELAYED_PAGES as default value?

review: Approve
Revision history for this message
Cris Dywan (kalikiana) wrote :

Let's leave the defaults as they are and re-visit this in the next cycle, if there's a chance that we merge the settings it would be pointless to move the cheese back and forth now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: