Midori Web Browser

Merge lp://qastaging/~midori/midori/noShadowBrowserSaveUri into lp://qastaging/midori

  1. noShadowBrowserSaveUri
  2. Merge into trunk
Proposed by Cris Dywan
Status: Merged
Approved by: gue5t gue5t
Approved revision: 6956
Merged at revision: 6990
Proposed branch: lp://qastaging/~midori/midori/noShadowBrowserSaveUri
Merge into: lp://qastaging/midori
Diff against target: 19 lines (+4/-4)
1 file modified
midori/midori-browser.c (+4/-4)
To merge this branch: bzr merge lp://qastaging/~midori/midori/noShadowBrowserSaveUri
Reviewer Review Type Date Requested Status
gue5t gue5t Approve
Review via email: mp+258576@code.qastaging.launchpad.net

Commit message

Don't shadow variable uri in midori_browser_save_uri

To post a comment you must log in.
Revision history for this message
gue5t gue5t (gue5t) wrote :

Is there a user-observable effect of passing destination_uri where we passed NULL before?

Revision history for this message
gue5t gue5t (gue5t) :
review: Needs Information
Revision history for this message
Cris Dywan (kalikiana) wrote :

Yes. The "uri" argument to midori_view_save_source is the website or file from the web, the "outfile" argument is the filename on disk. If you don't pass the outfile you end up with heuristics for coming up with a filename, which can only be harmful or at best do nothing given that we already have the exact desired filename selected by the user.

Revision history for this message
gue5t gue5t (gue5t) wrote :

Sounds good. Thanks for the explanation!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: