Midori Web Browser

Merge lp://qastaging/~midori/midori/openMenuSymbolic into lp://qastaging/midori

  1. openMenuSymbolic
  2. Merge into trunk
Proposed by Cris Dywan
Status: Needs review
Proposed branch: lp://qastaging/~midori/midori/openMenuSymbolic
Merge into: lp://qastaging/midori
Diff against target: 20 lines (+3/-1)
1 file modified
midori/midori-browser.c (+3/-1)
To merge this branch: bzr merge lp://qastaging/~midori/midori/openMenuSymbolic
Reviewer Review Type Date Requested Status
Midori Devs Pending
Review via email: mp+269580@code.qastaging.launchpad.net

Commit message

Use open-menu-(symbolic) for app menu

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

This doesn't seem to use fallbacks correctly because of using gicon. Normally it would fallback from open-menu-symbolic to open-menu (just by using gtk image from icon name), but instead it's falling back across icon themes to find open-menu-symbolic (which is not desirable, imo)

Reply
Revision history for this message
Cris Dywan (kalikiana) wrote :

I don't know what else to do then. This is how GTK+ implements icon themes.

Reply

Unmerged revisions

7032. By Cris Dywan

Use open-menu-(symbolic) for app menu

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: