Merge lp://qastaging/~midori/midori/snapcraft into lp://qastaging/midori
Proposed by
Cris Dywan
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Cody Garver | ||||
| Approved revision: | 7171 | ||||
| Merged at revision: | 7166 | ||||
| Proposed branch: | lp://qastaging/~midori/midori/snapcraft | ||||
| Merge into: | lp://qastaging/midori | ||||
| Diff against target: |
185 lines (+121/-21) 4 files modified
config/CMakeLists.txt (+1/-1) midori/midori-app.c (+5/-17) midori/midori-view.c (+6/-3) snap/snapcraft.yaml (+109/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~midori/midori/snapcraft | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Cody Garver (community) | Approve | ||
| axlrose112 | Pending | ||
|
Review via email:
|
|||
Commit message
Snap packaging
Description of the change
Adds a snapcraft.yaml to build a Midori snap, built with WebKit2 and GTK+3.
This also includes a CMake build fix, a missing icon info NULL-check and uses a simpler hash for the GApplication.name exposed over DBus so that it works with confinement.
To post a comment you must log in.
Revision history for this message
| axlrose112 (axlrose112) wrote | # |
Revision history for this message
| RabbitBot (rabbitbot-a) wrote | # |
Revision history for this message
| Cody Garver (codygarver) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I got Segmentation fault and after ran it with gb I got:
Program received signal SIGSEGV, Segmentation fault.
0x00000008008c18de in midori_
at /home/jamesaxl/
449 g_warning ("Could not load pixbuf for icon '%s': %s\n", icon_name, error->message);