Midori Web Browser

Merge lp://qastaging/~midori/midori/trustyGtk3.10 into lp://qastaging/midori

  1. trustyGtk3.10
  2. Merge into trunk
Proposed by Cris Dywan
Status: Merged
Approved by: gue5t gue5t
Approved revision: 6970
Merged at revision: 6971
Proposed branch: lp://qastaging/~midori/midori/trustyGtk3.10
Merge into: lp://qastaging/midori
Diff against target: 34 lines (+3/-3)
2 files modified
CMakeLists.txt (+2/-2)
midori/midori-window.vala (+1/-1)
To merge this branch: bzr merge lp://qastaging/~midori/midori/trustyGtk3.10
Reviewer Review Type Date Requested Status
Cody Garver (community) Disapprove
gue5t gue5t Approve
Review via email: mp+261898@code.qastaging.launchpad.net

Commit message

Stop using Gtk.Entry.max_width_chars

To post a comment you must log in.
Revision history for this message
gue5t gue5t (gue5t) wrote :

(from IRC: this API isn't available until GTK+3.12, and we don't really want it anyway; this switches to code that's known to work with GTK+3.10 and accurately reflects what versions do work in the configure script.)

Looks good to me.

review: Approve
Revision history for this message
Cody Garver (codygarver) wrote :

This breaks the headerbar's address bar, it does not expand width http://i.imgur.com/IuThMNI.jpg

review: Disapprove
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Those might help: gtk_widget_set_hexpand / gtk_widget_set_hexpand_set

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: