Ubuntu Calendar App

Merge lp://qastaging/~mihirsoni/ubuntu-calendar-app/limitLablesModel into lp://qastaging/ubuntu-calendar-app

  1. limitLablesModel
  2. Merge into trunk
Proposed by Mihir Soni
Status: Merged
Approved by: Kunal Parmar
Approved revision: 522
Merged at revision: 521
Proposed branch: lp://qastaging/~mihirsoni/ubuntu-calendar-app/limitLablesModel
Merge into: lp://qastaging/ubuntu-calendar-app
Diff against target: 72 lines (+16/-12)
3 files modified
Defines.js (+1/-6)
EventRepetition.qml (+5/-1)
LimitLabelModel.qml (+10/-5)
To merge this branch: bzr merge lp://qastaging/~mihirsoni/ubuntu-calendar-app/limitLablesModel
Reviewer Review Type Date Requested Status
Kunal Parmar Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Arto Jalkanen (community) Approve
Review via email: mp+239194@code.qastaging.launchpad.net

Commit message

Moved limitLabels from object to ListModel

Description of the change

Moved limitLabels from object to ListModel

To post a comment you must log in.
Revision history for this message
Arto Jalkanen (ajalkane) wrote :

Looks good, so I'm just going to nitpick: the function() definition is intended too deep.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:520
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/956/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1164
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1164/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/514

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/956/rebuild

review: Approve (continuous-integration)
Revision history for this message
Arto Jalkanen (ajalkane) wrote :

So yeah, I'll approve and you'll consider whether to change the indentation.

review: Approve
lp://qastaging/~mihirsoni/ubuntu-calendar-app/limitLablesModel updated
521. By Mihir Soni

Indentation issues

522. By Mihir Soni

reverted pot changes

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:522
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/958/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1177
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1177/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/516

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/958/rebuild

review: Approve (continuous-integration)
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

seems good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: