Merge lp://qastaging/~mikemc/charms/trusty/glance-simplestreams-sync/add-source-config into lp://qastaging/charms/trusty/glance-simplestreams-sync

Proposed by Mike McCracken
Status: Merged
Merged at revision: 61
Proposed branch: lp://qastaging/~mikemc/charms/trusty/glance-simplestreams-sync/add-source-config
Merge into: lp://qastaging/charms/trusty/glance-simplestreams-sync
Prerequisite: lp://qastaging/~freyes/charms/trusty/glance-simplestreams-sync/lp1522929
Diff against target: 37 lines (+19/-0)
2 files modified
config.yaml (+18/-0)
hooks/hooks.py (+1/-0)
To merge this branch: bzr merge lp://qastaging/~mikemc/charms/trusty/glance-simplestreams-sync/add-source-config
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Review via email: mp+282806@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2016-01-15.

Commit message

Add 'source' and 'key' config options to support adding a PPA source for packages installed by the charm.

Description of the change

Add 'source' and 'key' config options to support adding a PPA source for packages installed by the charm.

This is potentially generally useful but is motivated by wanting the cloud-installer/simplestreams-testing PPA on trusty. That PPA had been unconditionally installed, but that was causing issues and will be removed by this branch: https://code.launchpad.net/~freyes/charms/trusty/glance-simplestreams-sync/lp1522929/+merge/279644

This option allows us to add that PPA only when required.

To post a comment you must log in.
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches