Merge lp://qastaging/~mikemc/charms/trusty/glance-simplestreams-sync/fix-1493932 into lp://qastaging/charms/trusty/glance-simplestreams-sync

Proposed by Mike McCracken
Status: Merged
Merged at revision: 54
Proposed branch: lp://qastaging/~mikemc/charms/trusty/glance-simplestreams-sync/fix-1493932
Merge into: lp://qastaging/charms/trusty/glance-simplestreams-sync
Prerequisite: lp://qastaging/~openstack-charmers/charms/trusty/glance-simplestreams-sync/next
Diff against target: 20 lines (+1/-2)
1 file modified
scripts/glance-simplestreams-sync.py (+1/-2)
To merge this branch: bzr merge lp://qastaging/~mikemc/charms/trusty/glance-simplestreams-sync/fix-1493932
Reviewer Review Type Date Requested Status
Felipe Reyes Approve
charmers Pending
Review via email: mp+270578@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-09-09.

Commit message

Avoid cleaning up lock file when we didn't get the lock. Fixes LP# 1493932

Description of the change

Avoid cleaning up lock file when we didn't get the lock.

If more than one sync job runs while a first one is downloading the image, this would result in a second (or more) identical set of images being synced.

To post a comment you must log in.
Revision history for this message
Felipe Reyes (freyes) wrote :

+1 Looks good to me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches