Merge lp://qastaging/~mikemc/ubuntuone-client/fix-dirty-reactor-test-ext-intf into lp://qastaging/ubuntuone-client
Proposed by
Mike McCracken
| Status: | Merged |
|---|---|
| Approved by: | dobey |
| Approved revision: | 1364 |
| Merged at revision: | 1365 |
| Proposed branch: | lp://qastaging/~mikemc/ubuntuone-client/fix-dirty-reactor-test-ext-intf |
| Merge into: | lp://qastaging/ubuntuone-client |
| Diff against target: |
25 lines (+3/-2) 1 file modified
tests/platform/ipc/test_external_interface.py (+3/-2) |
| To merge this branch: | bzr merge lp://qastaging/~mikemc/ubuntuone-client/fix-dirty-reactor-test-ext-intf |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| dobey (community) | Approve | ||
| Roberto Alsina (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- Fix AutoconnectConf
Description of the change
- Fix test that called a function returning deferred and never waited for answer.
This test doesn't fail on linux or windows, but apparently never evaluated its assertions either. It was only caught on darwin because of a dirty reactor error in the PB IPC, which surprisingly doesn't happen on windows.
You can test just this test with some version of the following command (The following is for darwin).
u1trial -t tests.platform.
To post a comment you must log in.
Revision history for this message
| Roberto Alsina (ralsina) | # |
review:
Approve
Revision history for this message
| dobey (dobey) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
