Merge lp://qastaging/~mikemc/ubuntuone-client/fix-networkstate-manythreads into lp://qastaging/ubuntuone-client
Proposed by
Mike McCracken
| Status: | Merged |
|---|---|
| Approved by: | dobey |
| Approved revision: | 1369 |
| Merged at revision: | 1367 |
| Proposed branch: | lp://qastaging/~mikemc/ubuntuone-client/fix-networkstate-manythreads |
| Merge into: | lp://qastaging/ubuntuone-client |
| Prerequisite: | lp://qastaging/~mikemc/ubuntuone-client/use-IPCError-in-PB |
| Diff against target: |
61 lines (+21/-2) 1 file modified
tests/platform/ipc/test_perspective_broker.py (+21/-2) |
| To merge this branch: | bzr merge lp://qastaging/~mikemc/ubuntuone-client/fix-networkstate-manythreads |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| dobey (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- Mock out NetworkState in IPCTestCase, avoids starting a thread per test case on darwin and windows.
Description of the change
- Mock out NetworkState in IPCTestCase, avoids starting a thread per test case on darwin and windows.
Since IPCTestCase subclasses do not test network state handling, a simple mock that always returns ONLINE works fine, and avoids starting a ton of threads that never exit.
This appears to be more of a problem on darwin than on windows, but it can't hurt.
To post a comment you must log in.
Revision history for this message
| dobey (dobey) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
