Merge lp://qastaging/~mikemc/ubuntuone-client/fix-test-main-use-fake-monitor into lp://qastaging/ubuntuone-client
Proposed by
Mike McCracken
| Status: | Merged |
|---|---|
| Approved by: | dobey |
| Approved revision: | 1371 |
| Merged at revision: | 1373 |
| Proposed branch: | lp://qastaging/~mikemc/ubuntuone-client/fix-test-main-use-fake-monitor |
| Merge into: | lp://qastaging/ubuntuone-client |
| Diff against target: |
22 lines (+3/-2) 1 file modified
tests/syncdaemon/test_main.py (+3/-2) |
| To merge this branch: | bzr merge lp://qastaging/~mikemc/ubuntuone-client/fix-test-main-use-fake-monitor |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michał Karnicki (community) | Approve | ||
| Roberto Alsina (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- Use fake FS Monitor to avoid starting PB IPC connections that don't get stopped correctly.
Description of the change
- Use fake FS Monitor to avoid starting PB IPC connections that don't get stopped correctly.
SYMPTOM: on darwin, without this branch, the following command:
% u1trial --reactor=twisted tests/syncdaemo
spews a ton of dirty reactor errors.
With this branch, the tests are faster and quieter.
the above command also works fine on windows/linux with this branch.
To post a comment you must log in.
Revision history for this message
| Michał Karnicki (karni) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Oh, clever.