Merge lp://qastaging/~mikemc/ubuntuone-ios-files/limit-upload-queued-notifications into lp://qastaging/ubuntuone-ios-files
Proposed by
Mike McCracken
| Status: | Merged |
|---|---|
| Approved by: | dobey |
| Approved revision: | 102 |
| Merged at revision: | 104 |
| Proposed branch: | lp://qastaging/~mikemc/ubuntuone-ios-files/limit-upload-queued-notifications |
| Merge into: | lp://qastaging/ubuntuone-ios-files |
| Prerequisite: | lp://qastaging/~mikemc/ubuntuone-ios-files/quiet-crashlytics |
| Diff against target: |
32 lines (+5/-6) 2 files modified
Files/U1AutoUploadsManager.m (+0/-5) Files/U1FilesClient.m (+5/-1) |
| To merge this branch: | bzr merge lp://qastaging/~mikemc/ubuntuone-ios-files/limit-upload-queued-notifications |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| dobey (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- Remove redundant notification for upload queueing
Description of the change
- Remove redundant notification for upload queueing
This change further reduces overhead by only posting one notification when an upload operation is queued, and coalescing it.
The display code that listens for these notifications to set the pending upload badge in the tab bar at the bottom is really slow, so we need to avoid poking it too often.
To post a comment you must log in.
Revision history for this message
| Mike McCracken (mikemc) wrote | # |
Revision history for this message
| dobey (dobey) | # |
review:
Approve
Revision history for this message
| Ubuntu One Auto Pilot (otto-pilot) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
6 -// Copyright 2011 Canonical Ltd.
7 +// Copyright 2013 Canonical Ltd.
2011-2013 and more of same changes as other branches, yada yada.