Merge lp://qastaging/~mikemc/ubuntuone-ios-files/selfish-hasher into lp://qastaging/ubuntuone-ios-files
Proposed by
Mike McCracken
| Status: | Merged |
|---|---|
| Approved by: | Mike McCracken |
| Approved revision: | 108 |
| Merged at revision: | 107 |
| Proposed branch: | lp://qastaging/~mikemc/ubuntuone-ios-files/selfish-hasher |
| Merge into: | lp://qastaging/ubuntuone-ios-files |
| Diff against target: |
102 lines (+8/-16) 5 files modified
Files/U1Hasher.h (+0/-1) Files/U1Hasher.m (+0/-9) Files/U1MagicUploadDataProvider.h (+2/-0) Files/U1MagicUploadDataProvider.m (+3/-3) FilesTests/U1HasherTest.m (+3/-3) |
| To merge this branch: | bzr merge lp://qastaging/~mikemc/ubuntuone-ios-files/selfish-hasher |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| dobey (community) | Approve | ||
| Roberto Alsina (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- change to allow concurrent hashers
Description of the change
Remove sharedHasher method, so clients must instantiate their own hasher, and thus get their own semaphore, allowing multiple concurrent hashers.
also fix a memory leak found by the static analyzer
To post a comment you must log in.
Revision history for this message
| Roberto Alsina (ralsina) | # |
review:
Approve
Revision history for this message
| dobey (dobey) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
