Merge lp://qastaging/~mikemc/ubuntuone-ios-files/separate-hasher into lp://qastaging/ubuntuone-ios-files
Proposed by
Mike McCracken
| Status: | Merged |
|---|---|
| Approved by: | dobey |
| Approved revision: | 103 |
| Merged at revision: | 106 |
| Proposed branch: | lp://qastaging/~mikemc/ubuntuone-ios-files/separate-hasher |
| Merge into: | lp://qastaging/ubuntuone-ios-files |
| Prerequisite: | lp://qastaging/~mikemc/ubuntuone-ios-files/use-asset-ids-everywhere |
| Diff against target: |
420 lines (+318/-57) 4 files modified
Files/U1Hasher.h (+36/-0) Files/U1Hasher.m (+106/-0) Files/U1MagicUploadDataProvider.m (+52/-57) FilesTests/U1HasherTest.m (+124/-0) |
| To merge this branch: | bzr merge lp://qastaging/~mikemc/ubuntuone-ios-files/separate-hasher |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| dobey (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2013-05-20.
Commit message
- Consolidate hash generation into separate utility class.
Description of the change
- Consolidate hash generation into separate utility class
Adds simple tests for that class
To post a comment you must log in.
Revision history for this message
| dobey (dobey) wrote | # |
Revision history for this message
| dobey (dobey) | # |
review:
Needs Fixing
Revision history for this message
| Mike McCracken (mikemc) wrote | # |
Revision history for this message
| dobey (dobey) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
6 -// Copyright 2011 Canonical Ltd.
7 +// Copyright 2013 Canonical Ltd.
Should be changed to 2011-2013 instead.
Also, this branch seems to have the same changes as quite-crahlytics in the diff. Is that right? Or did something go wrong with the diff?