Merge lp://qastaging/~mikemc/ubuntuone-ios-files/use-options-menu into lp://qastaging/ubuntuone-ios-files
Proposed by
Mike McCracken
| Status: | Merged |
|---|---|
| Approved by: | dobey |
| Approved revision: | 110 |
| Merged at revision: | 108 |
| Proposed branch: | lp://qastaging/~mikemc/ubuntuone-ios-files/use-options-menu |
| Merge into: | lp://qastaging/ubuntuone-ios-files |
| Diff against target: |
71 lines (+8/-35) 2 files modified
Files/U1FileDetailsViewController.m (+4/-31) Files/U1FilePreviewViewController.m (+4/-4) |
| To merge this branch: | bzr merge lp://qastaging/~mikemc/ubuntuone-ios-files/use-options-menu |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| dobey (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Use "options menu" instead of "open-in" menu to let users do more things with downloaded files.
Description of the change
See bug LP: #1186362 for a screenshot of the new options menu from the simulator
presents a menu with a superset of functionality, adding useful things like save to photo roll or tweet/fb/weibo an image, or mail the file for other files.
NOTE, also adds an autorelease for the alert view, since it will leak. However, it looks like since you can always email a file, we may never create that alert view in the first place. Still.
To post a comment you must log in.
Revision history for this message
| dobey (dobey) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
