Linaro CI

Merge lp://qastaging/~milo/linaro-ci/bug1090416 into lp://qastaging/linaro-ci

bug1090416
Merge into lci-build-tools

Proposed by Milo Casagrande on 2012-12-17

Status:

Merged

Approved by:

James Tunnicliffe on 2013-01-07

Approved revision:

123

Merged at revision:

128

Proposed branch:

lp://qastaging/~milo/linaro-ci/bug1090416

Merge into:

lp://qastaging/linaro-ci

Diff against target:

344 lines (+141/-122)

5 files modified

get_latest_ci_hwpack (+122/-111)
jenkins_common_lib (+1/-1)
jenkins_kernel_build_inst (+9/-4)
jenkins_lava_job_submissions (+6/-3)
jenkins_packaged_kernel_build_inst (+3/-3)

To merge this branch:

bzr merge lp://qastaging/~milo/linaro-ci/bug1090416

Medium

Fix Released

Link a bug report

Reviewer	Date Requested	Status
James Tunnicliffe (community)		Approve on 2013-01-07
Deepti B. Kalakeri (community)	2012-12-17	Needs Fixing on 2012-12-21
Review via email: mp+140215@code.qastaging.launchpad.net

Commit message

Support sending LAVA jobs to multiple boards.

Description of the change

The branch adds support for sending multiple jobs to LAVA to different boards, from the same CI job.

It introduces a new env variable: board_types.
The old one can still be used in the CI jobs, but the new one will be exported, and it will be used looping through the defined boards.

Multiple boards have to be written comma separated.

Revision history for this message

Deepti B. Kalakeri (deeptik) wrote on 2012-12-21:

283 +elif test -n "$boards" -a -n "$board_type"; then
284 + board_types="$board_types,$board_type"

Typo error: elseif needs to be "elif test -n "$board_types" -a -n "$board_type"; than the above
between, I don't know why would anyone want to define board_types and board_type together in a job, instead if someone needed to define multiple board_types then they could just use board_types param or if they needed single board testing then they can use only board_type. I feel they are compliment params.

review: Needs Fixing

Revision history for this message

Milo Casagrande (milo) wrote on 2012-12-21:

On Fri, Dec 21, 2012 at 12:34 PM, Deepti B. Kalakeri
<email address hidden> wrote:
> Review: Needs Fixing
>
> 283 +elif test -n "$boards" -a -n "$board_type"; then
> 284 + board_types="$board_types,$board_type"
>
> Typo error: elseif needs to be "elif test -n "$board_types" -a -n "$board_type"; than the above
> between, I don't know why would anyone want to define board_types and board_type together in a job, instead if someone needed to define multiple board_types then they could just use board_types param or if they needed single board testing then they can use only board_type. I feel they are compliment params.

They are, or well should be: just one of them should be defined in the
job. Actually, it has been done in that way, introducing
'board_types', not to drop support for all the jobs that are already
using 'board_type'. Or we could just use 'board_type' even for
multiple boards.
All the if-elif code is just for using 'board_types' in the script,
and looping other it, instead of exporting both of them and having to
test which one is defined or not later.

--
Milo Casagrande
Infrastructure Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs

lp://qastaging/~milo/linaro-ci/bug1090416 updated on 2012-12-21