Merge lp://qastaging/~milo/linaro-image-tools/boards-refactoring into lp://qastaging/linaro-image-tools/11.11
Proposed by
Milo Casagrande
Status: | Merged |
---|---|
Merged at revision: | 596 |
Proposed branch: | lp://qastaging/~milo/linaro-image-tools/boards-refactoring |
Merge into: | lp://qastaging/linaro-image-tools/11.11 |
Prerequisite: | lp://qastaging/~milo/linaro-image-tools/hwpack-handler |
Diff against target: |
2224 lines (+773/-771) 2 files modified
linaro-media-create (+3/-3) linaro_image_tools/media_create/boards.py (+770/-768) |
To merge this branch: | bzr merge lp://qastaging/~milo/linaro-image-tools/boards-refactoring |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Sokolovsky | Approve | ||
linaro-image-tools maintainers | Pending | ||
Review via email: mp+138228@code.qastaging.launchpad.net |
Commit message
Boards class refactoring and clean-up.
Description of the change
Second, and a little big, merge request.
This is the initial refactoring work of the boards module moving from class methods to instance methods.
Some code needs further clean-up. In this branch tests have not been fixed.
To post a comment you must log in.
No reason was given for going from class to instance attributes, neither in commit message, nor in MR. Why would that matter? And character content of changes is massive, typo can lurk in easily. Merging this without passing tests is a bit brave IMHO.