Linaro Image Tools

Merge lp://qastaging/~milo/linaro-image-tools/bug1054422 into lp://qastaging/linaro-image-tools/11.11

bug1054422
Merge into trunk

Proposed by Milo Casagrande on 2012-09-24

Status:

Merged

Approved by:

Данило Шеган on 2012-09-24

Approved revision:

568

Merged at revision:

565

Proposed branch:

lp://qastaging/~milo/linaro-image-tools/bug1054422

Merge into:

lp://qastaging/linaro-image-tools/11.11

Diff against target:

99 lines (+36/-6)

4 files modified

linaro_image_tools/hwpack/hardwarepack.py (+3/-3)
linaro_image_tools/hwpack/hwpack_fields.py (+1/-1)
linaro_image_tools/hwpack/tests/test_config_v3.py (+29/-0)
linaro_image_tools/utils.py (+3/-2)

To merge this branch:

bzr merge lp://qastaging/~milo/linaro-image-tools/bug1054422

Critical

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Данило Шеган (community)	2012-09-24	Approve on 2012-09-24
Paul Sokolovsky	2012-09-24	Pending
Linaro Infrastructure	2012-09-24	Pending
Review via email: mp+125995@code.qastaging.launchpad.net

Description of the change

Changes in this MP fixes problem with bug 1054422. Added also some tests for Samsung specific fields.
There are also two minor fixes found while looking at the code.

Revision history for this message

Данило Шеган (danilo) wrote on 2012-09-24:

Looks good, thanks for the nice fix.

However small the other fixes are, we should generally strive to keep them in separate branches, especially for things where we plan to do a last-minute re-rollout of the tarball: it would be much better to include only relevant changes (it's not going to be obvious what's going on in the commit log if you lump these three changes together, no matter how verbose you make the commit message; it's neither going to be clear why were the other two changes critical and that they needed a .1 release :).

review: Approve

Revision history for this message

Milo Casagrande (milo) wrote on 2012-09-25:

Hi Danilo,

thanks for the review.

On Mon, Sep 24, 2012 at 9:18 PM, Данило Шеган <email address hidden> wrote:
>
> However small the other fixes are, we should generally strive to keep them in separate branches, especially for things where we plan to do a last-minute re-rollout of the tarball: it would be much better to include only relevant changes (it's not going to be obvious what's going on in the commit log if you lump these three changes together, no matter how verbose you make the commit message; it's neither going to be clear why were the other two changes critical and that they needed a .1 release :).

Yeah, I know, I was not sure to include them here.
I can merge only the two commits for the bug fix, and after the
rollout merge the remaining two with the small fixes.

--
Milo Casagrande
Infrastructure Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs