Merge lp://qastaging/~milo/linaro-image-tools/bug1057639 into lp://qastaging/linaro-image-tools/11.11

Proposed by Milo Casagrande
Status: Merged
Merged at revision: 568
Proposed branch: lp://qastaging/~milo/linaro-image-tools/bug1057639
Merge into: lp://qastaging/linaro-image-tools/11.11
Diff against target: 120 lines (+39/-10)
4 files modified
linaro-media-create (+8/-8)
linaro_image_tools/hwpack/hwpack_fields.py (+5/-0)
linaro_image_tools/media_create/__init__.py (+6/-2)
linaro_image_tools/media_create/boards.py (+20/-0)
To merge this branch: bzr merge lp://qastaging/~milo/linaro-image-tools/bug1057639
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Linaro Infrastructure Pending
Review via email: mp+127270@code.qastaging.launchpad.net

Description of the change

Branch adds default value for bootloader option when none is passed on the command line.
Default bootloader is set to 'u_boot'. A warning will be printed on the command line when no bootloader is specified.

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Good approach on issuing a warning in case explicit value is not provided (I assume we want user to know what bootloader they will use by specifying it themselves). Also assume that moving logging configuration section around was necessary.

review: Approve
571. By Milo Casagrande

Added default bootloader to option help.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches