Linaro Image Tools

Merge lp://qastaging/~milo/linaro-image-tools/dtb-files-support into lp://qastaging/linaro-image-tools/11.11

dtb-files-support
Merge into trunk

Proposed by Milo Casagrande on 2012-10-01

Status:

Merged

Approved by:

James Tunnicliffe on 2012-10-01

Approved revision:

571

Merged at revision:

569

Proposed branch:

lp://qastaging/~milo/linaro-image-tools/dtb-files-support

Merge into:

lp://qastaging/linaro-image-tools/11.11

Diff against target:

228 lines (+104/-4)

5 files modified

linaro_image_tools/hwpack/config.py (+20/-1)
linaro_image_tools/hwpack/hardwarepack.py (+9/-3)
linaro_image_tools/hwpack/hwpack_fields.py (+1/-0)
linaro_image_tools/hwpack/tests/test_config_v3.py (+19/-0)
linaro_image_tools/media_create/boards.py (+55/-0)

To merge this branch:

bzr merge lp://qastaging/~milo/linaro-image-tools/dtb-files-support

High

Fix Released

Link a bug report

Reviewer	Date Requested	Status
James Tunnicliffe (community)	2012-10-01	Approve on 2012-10-01
Paul Sokolovsky	2012-10-01	Pending
Review via email: mp+127224@code.qastaging.launchpad.net

Description of the change

Branch adds dtb_files support for hwpack config and metadata.
dtb_files syntax is:

dtb_files:
- destination.dtb : source.dtb

source.dtb can contain basic globbing.

Revision history for this message

James Tunnicliffe (dooferlad) wrote on 2012-10-01:

Looks good.

It would be nice if we could combine all the static files copying code into one place. This is similar to the boot files copying that we do, but not the same as copy_files (since those files stay in their packages).

There is definitely room for tidying up that whole code area, but a bug fix isn't the place for it. If you have nothing else to do I am sure it will be... entertaining :-)

review: Approve

Revision history for this message

Milo Casagrande (milo) wrote on 2012-10-02:

Hey James,

thanks for taking a look.

On Mon, Oct 1, 2012 at 5:14 PM, James Tunnicliffe
<email address hidden> wrote:
> Review: Approve
>
> Looks good.
>
> It would be nice if we could combine all the static files copying code into one place. This is similar to the boot files copying that we do, but not the same as copy_files (since those files stay in their packages).
>
> There is definitely room for tidying up that whole code area, but a bug fix isn't the place for it. If you have nothing else to do I am sure it will be... entertaining :-)

Indeed, I wanted to combine them, but it would have been a little bit
too much for the bug report.
I will indeed try to do it during this maintenance cycle, maybe in a
separate bug.

Ciao.

--
Milo Casagrande
Infrastructure Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs