Merge lp://qastaging/~milo/linaro-image-tools/hwpack-read into lp://qastaging/linaro-image-tools/11.11
| Status: | Merged |
|---|---|
| Approved by: | James Tunnicliffe |
| Approved revision: | 544 |
| Merged at revision: | 546 |
| Proposed branch: | lp://qastaging/~milo/linaro-image-tools/hwpack-read |
| Merge into: | lp://qastaging/linaro-image-tools/11.11 |
| Diff against target: |
459 lines (+360/-9) 6 files modified
linaro-media-create (+30/-7) linaro_image_tools/hwpack/hwpack_reader.py (+192/-0) linaro_image_tools/hwpack/tests/__init__.py (+1/-0) linaro_image_tools/hwpack/tests/test_hwpack_reader.py (+114/-0) linaro_image_tools/media_create/__init__.py (+6/-2) linaro_image_tools/utils.py (+17/-0) |
| To merge this branch: | bzr merge lp://qastaging/~milo/linaro-image-tools/hwpack-read |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Tunnicliffe (community) | Approve | ||
| Linaro Infrastructure | Pending | ||
|
Review via email:
|
|||
Description of the change
With this merge, there is the initial support for hwpack metadata reading, before creating an image with l-m-c.
What has been added here is:
- A new class for reading hwpack, that makes use of the HwpackHandler to open the tarball files
- New tests for the class
- New command line option --read-hwpack that reads the hwpack metadata and prints out information about the supported boards and bootlaoders
I also fixed a couple of PEP8 issues.
Notes:
- There is one test that will fail, and is related to pyflakes, looks like it is bug 812958 (I used getter and setter)
- Some of the required command line options have been set to False, since if we want to just read the hwpack and see what is supported, we should not require all the information. Since there is still work in progress on this, the bits handling the necessary command line options is still missing.
Looks fine now. Thanks for the changes.