Merge lp://qastaging/~milo/linaro-image-tools/regression-fix into lp://qastaging/linaro-image-tools/11.11

Proposed by Milo Casagrande
Status: Merged
Approved by: Fathi Boudra
Approved revision: 599
Merged at revision: 599
Proposed branch: lp://qastaging/~milo/linaro-image-tools/regression-fix
Merge into: lp://qastaging/linaro-image-tools/11.11
Diff against target: 103 lines (+27/-20)
2 files modified
linaro_image_tools/media_create/boards.py (+26/-19)
linaro_image_tools/media_create/tests/test_media_create.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~milo/linaro-image-tools/regression-fix
Reviewer Review Type Date Requested Status
Fathi Boudra Approve
Review via email: mp+142460@code.qastaging.launchpad.net

Description of the change

As reported on IRC this morning, we have a small regression after merging the code for Android hwpack.

This MP fixes the regression: a missing check on None strings.
It also addresses another change: the boot_args string, under some circumstance was coming out with a "None" inside, like this: "None root=/dev/mmcblk0p2 rootwait ro".

To post a comment you must log in.
Revision history for this message
Milo Casagrande (milo) wrote :

As reported on IRC this morning, we have a small regression after merging the code for Android hwpack.

This MP fixes the regression: a missing check on None strings.
It also addresses another change: the boot_args string, under some circumstance was coming out with a "None" inside, like this: "None root=/dev/mmcblk0p2 rootwait ro".

Revision history for this message
Fathi Boudra (fboudra) wrote :

ship it!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches