Mir

Merge lp://qastaging/~mir-team/mir/0.18.2 into lp://qastaging/mir/0.18

  1. 0.18.2
  2. Merge into 0.18
Proposed by Kevin DuBois
Status: Rejected
Rejected by: Kevin DuBois
Proposed branch: lp://qastaging/~mir-team/mir/0.18.2
Merge into: lp://qastaging/mir/0.18
Diff against target: 277 lines (+122/-14)
6 files modified
debian/changelog (+15/-1)
src/platforms/android/server/android_alloc_adaptor.cpp (+1/-1)
src/platforms/android/server/device_quirks.cpp (+24/-4)
src/platforms/android/server/device_quirks.h (+2/-0)
tests/unit-tests/graphics/android/test_android_alloc_adaptor.cpp (+32/-7)
tests/unit-tests/graphics/android/test_device_detection.cpp (+48/-1)
To merge this branch: bzr merge lp://qastaging/~mir-team/mir/0.18.2
Reviewer Review Type Date Requested Status
Kevin DuBois (community) Disapprove
Daniel van Vugt Needs Information
Review via email: mp+283955@code.qastaging.launchpad.net

Commit message

MP for Temporary silo to address lp: #1517205 and to provide additional quirk.

Description of the change

MP for Temporary silo to address lp: #1517205 and to provide additional quirk.

To post a comment you must log in.
lp://qastaging/~mir-team/mir/0.18.2 updated
3194. By Kevin DuBois

 port over quirk bits

3195. By Kevin DuBois

capture 0.18.1 release sig

3196. By Kevin DuBois

update the changelog appropriately

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The target branch contains additional fixes already that you haven't mentioned in the changelog. See: https://bugs.launchpad.net/mir/+milestone/0.18.2

review: Needs Fixing
lp://qastaging/~mir-team/mir/0.18.2 updated
3197. By Daniel van Vugt

debian/changelog: Mention other fixes already landed.

3198. By Daniel van Vugt

Remove questionmark

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fixed the changelog. But is that right? Are you really fixing bug 1517205 with this?

review: Needs Information
Revision history for this message
Kevin DuBois (kdub) wrote :

@Daniel, walked back some of the changes yesterday and didn't get a chance to update this MP.

More likely than not, there won't be a 0.18.2, as 0.19.0 will contain what is needed by PES. This was set up as a contingency release in case 0.19.0 got blocked.

I'll self-disapprove for now before taking this down when 0.19 is released.

review: Disapprove

Unmerged revisions

3198. By Daniel van Vugt

Remove questionmark

3197. By Daniel van Vugt

debian/changelog: Mention other fixes already landed.

3196. By Kevin DuBois

update the changelog appropriately

3195. By Kevin DuBois

capture 0.18.1 release sig

3194. By Kevin DuBois

 port over quirk bits

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: