Mir

Merge lp://qastaging/~mir-team/mir/lazy-cookie-secret-creation into lp://qastaging/mir

lazy-cookie-secret-creation
Merge into development-branch

Proposed by Brandon Schaefer on 2016-02-26

Status:

Work in progress

Proposed branch:

lp://qastaging/~mir-team/mir/lazy-cookie-secret-creation

Merge into:

lp://qastaging/mir

Diff against target:

88 lines (+20/-9)

3 files modified

src/cookie/authority.cpp (+18/-7)
tests/acceptance-tests/test_server_startup.cpp (+1/-1)
tests/unit-tests/test_mir_cookie.cpp (+1/-1)

To merge this branch:

bzr merge lp://qastaging/~mir-team/mir/lazy-cookie-secret-creation

Related bugs:

Bug #1536662: [regression] Black screen: Mir hangs and then crashes on startup/login due to reading from /dev/random	Critical	Fix Released
Bug #1541188: [regression] Tests fail with: std::exception::what: Failed to read from device: /dev/random after: 30 seconds	Medium	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel van Vugt			Disapprove on 2016-02-29
Mir CI Bot	continuous-integration		Needs Fixing on 2016-02-27
Cemil Azizoglu (community)		2016-02-26	Needs Fixing on 2016-02-26
Review via email: mp+287372@code.qastaging.launchpad.net

Commit message

Delay creating the secret so we dont block on /dev/random on boot.

Description of the change

Delay creating the secret so we dont block on /dev/random on boot.

Tested by:

You can check the entropy pool:
watch -n 0.1 cat /proc/sys/kernel/random/entropy_avail

PrePatch (ie. bug)
In a ssh session or tty1 "cat /dev/random" // eats up all the entropy
log into unity8 (Black screen and nothing!)

With this patch:
cat /dev/random again
log into unity8 (while smashing on the keys/mouse to attempt to get the secret created)
login works!

Note there was also discussion to remove create_saving, which we can remove. Just wanted to create this quick fix with out breaking API/ABI of the libcookie. Ill be creating a branch soon to remove that create function + a function that returns the secret.

lp://qastaging/~mir-team/mir/lazy-cookie-secret-creation updated on 2016-02-26

3347. By Brandon Schaefer on 2016-02-26: * Enable the regession tests

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-26:

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/424/rebuild

review: Approve (continuous-integration)

Revision history for this message

Cemil Azizoglu (cemil-azizoglu) wrote on 2016-02-26:

16 + BOOST_THROW_EXCEPTION(std::logic_error("Secret size " + std::to_string(passed_secret.size()) + " is to small, require " +

1. Line too long.
2. s/"to small"/"too small"

review: Needs Fixing

lp://qastaging/~mir-team/mir/lazy-cookie-secret-creation updated on 2016-02-26

3348. By Brandon Schaefer on 2016-02-26: * Fix throw

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-27:

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/425/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-02-27:

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/426/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2016-02-29:

You're only deferring the problem and not solving it. This branch simply moves the hang/crash to a later location where the regression tests don't cover it any more.

So you need new regression tests to cover the new code here, and to prove that at no stage during executing does Mir hang indefinitely or crash due to lack of entropy.

Needs fixing: No test coverage

also Disapprove: The best you can achieve this with approach is to move the hang+crash to a later location. And that's still not acceptable.

review: Disapprove

Unmerged revisions

3348. By Brandon Schaefer on 2016-02-26: * Fix throw
3347. By Brandon Schaefer on 2016-02-26: * Enable the regession tests
3346. By Brandon Schaefer on 2016-02-26: * Delay making the secret if no one wants one right away