Mir

Merge lp://qastaging/~mir-team/mir/no-priv-headers-in-platforms-3 into lp://qastaging/mir

Proposed by Cemil Azizoglu
Status: Work in progress
Proposed branch: lp://qastaging/~mir-team/mir/no-priv-headers-in-platforms-3
Merge into: lp://qastaging/mir
Prerequisite: lp://qastaging/~cemil-azizoglu/mir/no-priv-headers-in-platforms-2
Diff against target: 10 lines (+0/-0)
0 files modified
To merge this branch: bzr merge lp://qastaging/~mir-team/mir/no-priv-headers-in-platforms-3
Reviewer Review Type Date Requested Status
Alan Griffiths Abstain
Mir CI Bot continuous-integration Approve
Review via email: mp+308939@code.qastaging.launchpad.net

Commit message

Publish some headers from src/include/platform.

Description of the change

Publish some headers from src/include/platform. These should be noncontroversial. There are others however, so this MP is not enough to remove the path from CMakeList.

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:3779
https://mir-jenkins.ubuntu.com/job/mir-ci/2030/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/2600
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2663
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2655
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2655
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2655
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2629
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2629/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2629
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2629/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2629
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2629/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/2629
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/2629/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2629
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2629/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2629
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2629/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2030/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

We certainly need to publish more to enable downstream platforms, but I'm not entirely convinced now is the right time to be doing this.

review: Abstain
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I won't block progress. But I wish we had achieved the original vision of a driver model that doesn't have two-way linkage between Mir and the driver.

And failing that, I also wish we had fewer headers and the ability to re-privatise some of them before so many get stuck in public.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It's also worth remembering that external drivers will be bound by the licenses we use in these headers. Presently that's LGPL, which is more appropriate than GPL, but still unacceptable for some proprietary vendors.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

program_option.h: I've been thinking we could avoid exposing this dependency to drivers. Instead of drivers parsing command line options, users could provide options specific to a driver like:
  myserver --load mesa-kms.so:VT=1

Alternatively, we could audit all the driver-specific options and possibly find they're actually kind of common. So move them all to libmirserver and just optionally implement the behaviour in drivers as appropriate.

Unmerged revisions

3779. By Cemil Azizoglu

Publish various platform headers. These should be safe to publish.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches