Mir

Merge lp://qastaging/~mir-team/mir/set-state-remove-mir-wait into lp://qastaging/mir

  1. set-state-remove-mir-wait
  2. Merge into development-branch
Proposed by Brandon Schaefer
Status: Rejected
Rejected by: Brandon Schaefer
Proposed branch: lp://qastaging/~mir-team/mir/set-state-remove-mir-wait
Merge into: lp://qastaging/mir
Prerequisite: lp://qastaging/~mir-team/mir/remove-mir-wait-handle-persistent-id
Diff against target: 255 lines (+74/-46)
6 files modified
include/client/mir_toolkit/mir_surface.h (+2/-3)
src/client/mir_surface_api.cpp (+20/-11)
tests/acceptance-tests/test_client_library.cpp (+29/-20)
tests/acceptance-tests/test_client_surface_events.cpp (+10/-6)
tests/acceptance-tests/test_shell_control_of_surface_configuration.cpp (+8/-4)
tests/acceptance-tests/test_surface_modifications.cpp (+5/-2)
To merge this branch: bzr merge lp://qastaging/~mir-team/mir/set-state-remove-mir-wait
Reviewer Review Type Date Requested Status
Cemil Azizoglu (community) Needs Fixing
Alan Griffiths Needs Information
Mir CI Bot continuous-integration Needs Fixing
Review via email: mp+314755@code.qastaging.launchpad.net

Commit message

Remove the wait handle for set_state and use the old version for tests.

Description of the change

Remove the wait handle for set_state and use the old version for tests.

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3936
https://mir-jenkins.ubuntu.com/job/mir-ci/2698/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/3504/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3572
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3562
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3562
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3562
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3531
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3531/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3531
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3531/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3531/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3531
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3531/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3531
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3531/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3531
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3531/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2698/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Using the old version seems like storing up problems for later.

/1/ We should have tests that validate the new versions.

/2/ While the old versions do need tests in this release, they are going to be deleted in 0.1.

I'd like to see corresponding tests covering both new and old APIs (and the latter tests can simply be deleted with the APIs).

review: Needs Information
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

I agree with Alan.

We need to port the instances where this API is used to the new way including the tests. In the process of doing that we'll eliminate the possibility of releasing something that isn't useful/useable. We won't know that until/unless we do the work ourselves.

Don't worry about the time too much. Let's do the right thing.

review: Needs Fixing

Unmerged revisions

3936. By Brandon Schaefer

* Remove mir_wait_handle

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches