Merge ~mitchdz/ubuntu/+source/multipath-tools:mitch/manually_restart_multipathd_on_upgrade_to_systemd_only_package-lunar into ubuntu/+source/multipath-tools:ubuntu/lunar-devel

Thanks, some questions inline.

I removed the extra systemctl --system daemon-reload >/dev/null || true

Back to this today.

I'm taking a step back and going back to the original bug[1] that started this rabbit hole, trying to understand how we ended up here.

1. https://bugs.launchpad.net/ubuntu/+source/multipath-tools/+bug/2000186

Hi Andreas, I did some testing on the current package. I did 3 tests here and I am satisfied with them. Let me know what you think. I did the following:

1. Testing restart on package upgrade
2. Installing a fresh package (no warning message here because dpkg compare is lt-nl)
3. Upgrading to a future package

-----

1. Testing restart on package upgrade

$ lxc shell launch ubuntu:lunar l --vm
$ alias lxcrun="lxc exec l --"
$ lxcrun dpkg -l multipath-tools | grep multipath-tools | awk '{print $3}'
$ lxcrun pidof multipathd
137
$ lxcrun add-apt-repository ppa:mitchdz/multipath-tools-2035098 -y
$ lxcrun apt install -y multipath-tools=0.8.8-1ubuntu2.2~lunar5
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
  kpartx
Suggested packages:
  multipath-tools-boot
The following packages will be upgraded:
  kpartx multipath-tools
2 upgraded, 0 newly installed, 0 to remove and 2 not upgraded.
Need to get 365 kB of archives.
After this operation, 1024 B disk space will be freed.
Get:1 https://ppa.launchpadcontent.net/mitchdz/multipath-tools-2035098/ubuntu lunar/main amd64 kpartx amd64 0.8.8-1ubuntu2.2~lunar5 [30.4 kB]
Get:2 https://ppa.launchpadcontent.net/mitchdz/multipath-tools-2035098/ubuntu lunar/main amd64 multipath-tools amd64 0.8.8-1ubuntu2.2~lunar5 [335 kB]
Fetched 365 kB in 2s (167 kB/s)
(Reading database ... 57593 files and directories currently installed.)
Preparing to unpack .../kpartx_0.8.8-1ubuntu2.2~lunar5_amd64.deb ...
Unpacking kpartx (0.8.8-1ubuntu2.2~lunar5) over (0.8.8-1ubuntu2) ...
Preparing to unpack .../multipath-tools_0.8.8-1ubuntu2.2~lunar5_amd64.deb ...
Unpacking multipath-tools (0.8.8-1ubuntu2.2~lunar5) over (0.8.8-1ubuntu2) ...
Setting up kpartx (0.8.8-1ubuntu2.2~lunar5) ...
Setting up multipath-tools (0.8.8-1ubuntu2.2~lunar5) ...
The following warning from stopping multipathd.service is safe to ignore. See (LP: #2035098).
Warning: The unit file, source configuration file or drop-ins of multipathd.service changed on
 disk. Run 'systemctl daemon-reload' to reload units.
Could not execute systemctl: at /usr/bin/deb-systemd-invoke line 145.
Removing obsolete conffile /etc/init.d/multipath-tools ...
Processing triggers for man-db (2.11.2-1) ...
Processing triggers for libc-bin (2.37-0ubuntu2.1) ...
Scanning processes...
Scanning linux images...

Running kernel seems to be up-to-date.

No services need to be restarted.

No containers need to be restarted.

No user sessions are running outdated binaries.

No VM guests are running outdated hypervisor (qemu) binaries on this host.
# lxcrun pidof multipathd
1959
# lxcrun systemctl status multipathd.{service,socket} | grep Active -B2

● multipathd.service - Device-Mapper Multipath Device Controller
     Loaded: loaded (/lib/systemd/system/multipathd.service; enabled; preset: enabled)
     Active: active (running) since Thu 2023-10-05 16:40:20 UTC; 1min 5s ago
--
○ multipathd.socket - multipathd control socket
 ...

Text suggestions, let me know what you think.

Thanks Andreas, I like your suggestions. I added them and formatted it a little differently. Also updated the bug report to mention the warning that will be seen when upgrading.

+1 and sponsored