Merge ~mitya57/compiz:python3.8 into compiz:master

Proposed by Dmitry Shachnev
Status: Merged
Approved by: Dmitry Shachnev
Approved revision: 9b2b4ee050b28a6805fa9f86f721a5210dd55d7d
Merged at revision: 91d70986b2ffe33c351c60e954cd03dc4d235564
Proposed branch: ~mitya57/compiz:python3.8
Merge into: compiz:master
Diff against target: 149 lines (+11/-17)
4 files modified
compizconfig/ccsm/ccm/Pages.py (+2/-4)
compizconfig/ccsm/ccm/Settings.py (+5/-7)
compizconfig/ccsm/ccm/Utils.py (+3/-4)
compizconfig/ccsm/ccm/Widgets.py (+1/-2)
Reviewer Review Type Date Requested Status
Alberts Muktupāvels Approve
Compiz Maintainers Pending
Review via email: mp+375644@code.qastaging.launchpad.net

Commit message

Use GLib.markup_escape_text instead of cgi.escape which was removed in Python 3.8.

Description of the change

I replaced all uses of cgi.escape with GLib.markup_escape_text.

Another solution would be using html.escape, but there is no need for extra import when GLib contains a function specifically designed for GMarkup (which Pango uses).

To post a comment you must log in.
Revision history for this message
Alberts Muktupāvels (muktupavels) :
review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches