Compiz

Merge lp://qastaging/~mitya57/compiz/lp1469086 into lp://qastaging/compiz/0.9.12

  1. lp1469086
  2. Merge into 0.9.12
Proposed by Dmitry Shachnev
Status: Merged
Approved by: Stephen M. Webb
Approved revision: 3960
Merged at revision: 3969
Proposed branch: lp://qastaging/~mitya57/compiz/lp1469086
Merge into: lp://qastaging/compiz/0.9.12
Prerequisite: lp://qastaging/~mitya57/compiz/switcher-plugins-in-default
Diff against target: 10 lines (+1/-1)
1 file modified
debian/compiz-gnome.gsettings-override (+1/-1)
To merge this branch: bzr merge lp://qastaging/~mitya57/compiz/lp1469086
Reviewer Review Type Date Requested Status
Stephen M. Webb Approve
Alberts Muktupāvels Approve
Compiz Maintainers Pending
Review via email: mp+265897@code.qastaging.launchpad.net

Commit message

debian/compiz-gnome.gsettings-override: Remove unityshell from active plugins, and add switcher.

Description of the change

Remove unityshell from compiz-gnome plugins, and add switcher.

We do not need Unity shell in the default profile (because Unity has its own profile, see debian/unity.ini). However without Unity, we need some kind of window switcher, so add switcher there.

This should make the GNOME Flashback (Compiz) session working again.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Alberts, can you please test it? Also, do you think we can remove unitymtgrabhandles too, or is it useful?

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

> Alberts, can you please test it? Also, do you think we can remove
> unitymtgrabhandles too, or is it useful?

Ok, I will build and test GNOME Flashback and Unity sessions with new users. I have no idea what unitymtgrabhandles do...

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

I think it's like the invisible borders you added in Metacity.

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

> I think it's like the invisible borders you added in Metacity.

Then not needed? gwd has invisible borders.

lp://qastaging/~mitya57/compiz/lp1469086 updated
3960. By Dmitry Shachnev

Remove unitymtgrabhandles as well

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

OK, removed.

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

First I had to merge these branches:
1) lp:~bregma/compiz/lp-1477978
2) lp:~bregma/compiz/lp-1477654

Then created new compiz1 user and logged in GNOME Flashback session. Unity plugin was not loaded and Alt+Tab worked - looks good.

Then created new compiz2 user and logged in Unity / Ubuntu session. Unity was loaded - looks good.

Only I am getting very big icons in Alt+Tab switcher, but that is different problem/bug.

review: Approve
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Thanks!

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Merge proposal for icon size bug:
https://code.launchpad.net/~albertsmuktupavels/compiz/fix-icon-size-in-switcher/+merge/265900

Revision history for this message
Stephen M. Webb (bregma) wrote :

The unitymtgrabhandles plugin actually has nothing to do with Unity: it adds touch screen support for window movement and resizing.

Still, it's optional and Gnome traditionally has abysmal support for touch screens so removing it from the profile will not hurt anything.

Removing Unity is the right thing.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches