Merge lp://qastaging/~mkhu/compiz/compiz-fix_gwd_crash_on_activating_actionmenu into lp://qastaging/compiz/0.9.8
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://qastaging/~mkhu/compiz/compiz-fix_gwd_crash_on_activating_actionmenu |
| Merge into: | lp://qastaging/compiz/0.9.8 |
| Diff against target: |
17 lines (+5/-2) 1 file modified
gtk/window-decorator/actionmenu.c (+5/-2) |
| To merge this branch: | bzr merge lp://qastaging/~mkhu/compiz/compiz-fix_gwd_crash_on_activating_actionmenu |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel van Vugt | Needs Resubmitting | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2012-11-06.
Description of the change
for an application window without decorations, pressing Alt+Space failed to activate the action menu on the top left corner of the window and also causes the gtk-window-
the crash is caused by a miscalculation in actionmenu.c: position_
function (*theme_
so first we need to check if the window is decorated or not.
most (non-overrided) windows use _MOTIF_WM_HINTS to indicate they're not to be decorated.
thus get_mwm_prop(...) in util.c is quite handy.
NOTE: (*theme_
BTW, how to propose merge to both lp:compiz/0.9.8 and lp:compiz/0.9.9 in a single pass
Unmerged revisions
- 3412. By hukang <email address hidden>
-
fix gtk-window-
decorator crash when pressing Alt+Space on windows without decorations (e.g. google-chrome)
Excellent, thanks.
Please:
1. Log a bug for the crash and link the branch to the bug.
2. Change the indentation to 4 spaces (not tabs except every second level to replace 8-spaces).
3. Propose for merging to lp:compiz only. That's 0.9.9