Ubuntu
totem package

Merge lp://qastaging/~mniess/ubuntu/trusty/totem/fix-lp1292262 into lp://qastaging/ubuntu/trusty/totem

  1. Trusty (14.04)
  2. fix-lp1292262
  3. Merge into trusty
Proposed by Matthias Niess
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp://qastaging/~mniess/ubuntu/trusty/totem/fix-lp1292262
Merge into: lp://qastaging/ubuntu/trusty/totem
Diff against target: 59 lines (+39/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/94-fix-subtitle-downloader.patch (+30/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://qastaging/~mniess/ubuntu/trusty/totem/fix-lp1292262
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Jackson Doak (community) Approve
Review via email: mp+212324@code.qastaging.launchpad.net

Description of the change

The subtitle downloader plugin in totem does not work (LP: #1292262).
The bug has been fixed upstream. This patch incorporates the fix.

To post a comment you must log in.
lp://qastaging/~mniess/ubuntu/trusty/totem/fix-lp1292262 updated
32. By Matthias Niess

target trusty and add dep-3 patch header

Revision history for this message
Jackson Doak (noskcaj) wrote :

All the changes look ok, approve from me.

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the work, I renamed the patch to start with "git-" since those fixes are upstream and it helps to know what is coming from there/can we dropped later. I've also commited to the right vcs which is lp:~ubuntu-desktop/totem/ubuntu (see Vcs-Bzr in the control file, or the apt-get source output)

review: Approve
Revision history for this message
Matthias Niess (mniess) wrote :

Thanks. I'll make sure to look at that next time!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches