Simple Scan

Merge lp://qastaging/~moimael/simple-scan/app-menu into lp://qastaging/~simple-scan-team/simple-scan/trunk

  1. app-menu
  2. Merge into trunk
Proposed by moimael
Status: Merged
Merged at revision: 677
Proposed branch: lp://qastaging/~moimael/simple-scan/app-menu
Merge into: lp://qastaging/~simple-scan-team/simple-scan/trunk
Diff against target: 354 lines (+188/-13)
5 files modified
data/Makefile.am (+1/-0)
data/simple-scan-menu.ui (+62/-0)
data/simple-scan.gresource.xml (+1/-0)
data/simple-scan.ui (+1/-1)
src/ui.vala (+123/-12)
To merge this branch: bzr merge lp://qastaging/~moimael/simple-scan/app-menu
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+200076@code.qastaging.launchpad.net

Description of the change

Add an app menu for gnome-shell.

To post a comment you must log in.
lp://qastaging/~moimael/simple-scan/app-menu updated
679. By moimael

Standardize Help/About/Quit

680. By moimael

Add accelerators back to app menu

Revision history for this message
Robert Ancell (robert-ancell) wrote :

I'm not 100% sure on the logic on showing the app menu, but works well.

Pushed with minor style changes, thanks!

review: Approve
Revision history for this message
moimael (moimael) wrote :

I took the logic from gedit so it should be ok :)

Please take a look on the bug report, there is a one liner patch you should apply to fix scrollbar (was introduced by the cleanup).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches