Simple Scan

Merge lp://qastaging/~moimael/simple-scan/remove-deprecated into lp://qastaging/~simple-scan-team/simple-scan/trunk

  1. remove-deprecated
  2. Merge into trunk
Proposed by moimael
Status: Merged
Merged at revision: 670
Proposed branch: lp://qastaging/~moimael/simple-scan/remove-deprecated
Merge into: lp://qastaging/~simple-scan-team/simple-scan/trunk
Diff against target: 1608 lines (+473/-368)
3 files modified
data/simple-scan.ui (+460/-355)
src/book-view.vala (+1/-1)
src/ui.vala (+12/-12)
To merge this branch: bzr merge lp://qastaging/~moimael/simple-scan/remove-deprecated
Reviewer Review Type Date Requested Status
Robert Ancell Approve
moimael (community) Needs Resubmitting
Review via email: mp+195432@code.qastaging.launchpad.net

Description of the change

Remove deprecated Gtk.Stock items and Gtk widgets (GtkVBox, GtkTable, GtkHButtonBox) and replace them with their newer counterparts. Also bump Gtk required version to 3.8 and rewamp glade file to work well with last glade release.

To post a comment you must log in.
lp://qastaging/~moimael/simple-scan/remove-deprecated updated
669. By moimael

Replace deprecated widgets (GtkVBox, GtkHButtonBox, GtkTable) and bump required GTK release to 3.8

Revision history for this message
Robert Ancell (robert-ancell) wrote :

The stock label replacements should be marked as translatable:
+ info_bar_close_button = (Gtk.Button) info_bar.add_button ("_Close", Gtk.ResponseType.CLOSE);

i.e. _("_Close")

review: Needs Fixing
lp://qastaging/~moimael/simple-scan/remove-deprecated updated
670. By moimael

Mark stock label replacements as translatable

Revision history for this message
moimael (moimael) wrote :

> The stock label replacements should be marked as translatable:
> + info_bar_close_button = (Gtk.Button) info_bar.add_button ("_Close",
> Gtk.ResponseType.CLOSE);
>
> i.e. _("_Close")

Done !

review: Needs Resubmitting
Revision history for this message
Robert Ancell (robert-ancell) :
review: Approve
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches