Drizzle

Merge lp://qastaging/~mordred/drizzle/bug702571 into lp://qastaging/drizzle/7.0

bug702571
Merge into 7.0

Proposed by Monty Taylor on 2011-01-13

Status:

Superseded

Proposed branch:

lp://qastaging/~mordred/drizzle/bug702571

Merge into:

lp://qastaging/drizzle/7.0

Diff against target:

585 lines (+106/-102)

13 files modified

plugin/innobase/handler/ha_innodb.cc (+48/-50)
plugin/innobase/include/srv0srv.h (+1/-1)
plugin/innobase/include/trx0sys.h (+2/-2)
plugin/innobase/srv/srv0srv.cc (+1/-1)
plugin/innobase/srv/srv0start.cc (+10/-11)
plugin/innobase/tests/r/innodb-system-table-view.result (+9/-9)
plugin/innobase/tests/r/innodb_bug53591.result (+3/-3)
plugin/innobase/tests/r/innodb_cmpmem.result (+8/-8)
plugin/innobase/tests/r/innodb_cmpmem_reset.result (+8/-8)
plugin/innobase/tests/t/innodb-system-table-view.test (+1/-1)
plugin/innobase/tests/t/innodb_cmpmem.test (+1/-0)
plugin/innobase/tests/t/innodb_cmpmem_reset.test (+1/-0)
plugin/innobase/trx/trx0sys.cc (+13/-8)

To merge this branch:

bzr merge lp://qastaging/~mordred/drizzle/bug702571

Wishlist

Won't Fix

Link a bug report

Reviewer	Review Type	Date Requested	Status
Stewart Smith (community)		2011-01-13	Needs Fixing on 2011-01-13
Review via email: mp+46205@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2011-01-15.

Description of the change

Sets innodb_file_per_table to on by default (which doesn't break things that were previously set to the other thing, btw) and sets O_DIRECT as the default innodb_flush_sync_method on linux.

Revision history for this message

Stewart Smith (stewart) wrote on 2011-01-13:

1) have you tested fallback for when O_DIRECT doesn't work? (if have ext3/4 mount with data=journal as it doesn't allow O_DIRECT)
2) defaults should also be changed in HailDB engine.

review: Needs Fixing

lp://qastaging/~mordred/drizzle/bug702571 updated on 2011-01-14

2082. By Brian Aker <brian@gir-3> on 2011-01-14: Rollup changes for trunk.

Revision history for this message

Monty Taylor (mordred) wrote on 2011-01-14:

Tested fallback? No - not any more than if a user supplied O_DIRECT as a config option - but it does appear that the code tests for the error, prints a warning "InnoDB: Failed to set O_DIRECT on file %s: %s: %s, continuing anyway\n" and goes on.

I'll see about changing them in haildb too though.

lp://qastaging/~mordred/drizzle/bug702571 updated on 2011-01-15

2083. By Lee Bieber on 2011-01-14: Merge Stewart - fix bug 582486: valgrind warning in drizzled::mysql_load
2084. By Lee Bieber on 2011-01-14: Merge Lee - fix rabbitmq test to use $TOP_SRCDIR instead of $TOP_BUILDDIR
2085. By Lee Bieber on 2011-01-14: Merge Stewart - track what is being called in the Storage Engine in storage_engine_api_tester
2086. By Lee Bieber on 2011-01-14: Merge Andrew - fix bug 702881: data_dictionary.tables row_format incorrect
Merge Marisa - Document new data types and change in build file to treat warnings as errors
Merge Lee - 690773: RabbitMQ plugin needs to start rabbitmq for its test
2087. By Lee Bieber on 2011-01-15: Merge Stewart - some documentation clean up
Merge Patrick - fix bug 693130: Tests depending on archive engine should be skipped if archive isn't enabled
Merge Patrick - fix bug 697292: The have_valgrind include file in the test has the opposite effect
2088. By Monty Taylor on 2011-01-15: Sets innodb_file_per_table. Also sets a default innodb_flush_method and changes default file format to Barracuda.