Drizzle

Merge lp://qastaging/~mordred/drizzle/remove-lint into lp://qastaging/drizzle/7.0

remove-lint
Merge into 7.0

Proposed by Monty Taylor on 2011-02-12

Status:	Merged
Approved by:	Monty Taylor on 2011-02-13
Approved revision:	2160
Merged at revision:	2166
Proposed branch:	lp://qastaging/~mordred/drizzle/remove-lint
Merge into:	lp://qastaging/drizzle/7.0
Diff against target:	4512 lines (+9/-4388) 12 files modified Makefile.am (+0/-6) config/lint-source.am (+0/-49) config/make-lint.py (+0/-159) config/uncrustify.cfg (+0/-1127) configure.ac (+0/-2) extra/clean_source.sh (+0/-22) extra/cpplint.py (+0/-2952) extra/include.am (+0/-23) extra/run_cpplint.sh (+0/-35) libdrizzle/include.am (+5/-0) libdrizzle/mysql_password_hash.cc (+4/-5) m4/pandora_run_cpplint.m4 (+0/-8)
To merge this branch:	bzr merge lp://qastaging/~mordred/drizzle/remove-lint
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Drizzle Developers		2011-02-12	Pending
Review via email: mp+49518@code.qastaging.launchpad.net

Description of the change

creating the lint.am file was taking forever on every invocation of make - so it pissed me off. WE haven't used that lint program in months... so it's GONE

Revision history for this message

Lee Bieber (kalebral-deactivatedaccount) wrote on 2011-02-13:

Monty, why don't we use this anymore??

Revision history for this message

Monty Taylor (mordred) wrote on 2011-02-13:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/12/2011 07:29 PM, Lee Bieber wrote:
> Monty, why don't we use this anymore??

A few reasons:

It actually checked very little. (only include guard naming)
It was expensive to run, so people rarely ran it.

So we essentially made a subconscious cost/benefit analysis and chose
against it. However, we were still paying the cost of setting up the
makefiles to be _able_ to run it.

I originally added it to the tree because I wanted to get us even
cleaner than just gcc warnings ... but to be honest, we haven't even
finished cleaning those, and it's gonna be a while until we do. :)

Monty
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1XdnQACgkQ2Jv7/VK1RgGjcgCgxT/o8mjXjTqMH1IypZajWcxq
PLIAnjkrVaL9hzYT4u40A9681bTWEc6Y
=AZn8
-----END PGP SIGNATURE-----