Merge lp://qastaging/~morphis/jenkins-launchpad-plugin/preemptive-auth-handler into lp://qastaging/jenkins-launchpad-plugin
Status: | Needs review |
---|---|
Proposed branch: | lp://qastaging/~morphis/jenkins-launchpad-plugin/preemptive-auth-handler |
Merge into: | lp://qastaging/jenkins-launchpad-plugin |
Diff against target: |
40 lines (+23/-2) 1 file modified
jlp/jsonjenkins.py (+23/-2) |
To merge this branch: | bzr merge lp://qastaging/~morphis/jenkins-launchpad-plugin/preemptive-auth-handler |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jenkaas Hackers | Pending | ||
Review via email:
|
Commit message
Use PreemptiveBasic
sent authentication headers with every request and not as urllib2 would
do when we receive a HTTP 403 error code.
Description of the change
Jenkins doesn't return a 401 HTTP error code to tell the client to retry with authentication details as urllib2 by default expects but sents a 403 error code straight away. See https:/
Unmerged revisions
- 134. By Simon Fels
-
Add missing import for base64 package
- 133. By Simon Fels
-
Use PreemptiveBasic
AuthHandler authentication handler to make sure we
sent authentication headers with every request and not as urllib2 would
do when we receive a HTTP 403 error code.