Thanks a lot for the first review round!

For 1: I must say I don't really like us separating stuff into multiple different approaches per product. We already have separate packaging branches for desktop and touch and adding a third one for snappy doesn't really scale. That there are debian patches which might not apply to snappy, stale patches etc. but those things are all sth we have to solve over time. We have to find one common approach for all projects we're doing and apply that to all projects the same way.

Also respect that we're already shipping snappy packages for 15.04 with the exact same approach we're doing here but just having the debian package unpacked in another git repo. So this is only a continuation of what we've done before but in a more packed way. I would really like to bring all the different work we're doing as close as possible together rather than investing a huge amount of time for development, testing, reviewing for all different projects. There will be always project specific development/testing/.. but we should aim for convergence. I know there are problems in practice but those are the bits we need to solve.

I am fine with adding the debian packaging version number.

For 2: Adding --enable-snappy was done with the aim to align our packaging as described for 1). The debian package would simply build with --disable-snappy.

For 3: I removed ModemManager as 
 
 * It needs to be in its own snap. The NetworkManager snap/part
   then just interacts with. What we did for 15.04 was a
   quick hack and is nothing we should just continue to do
   without discussing what we really want.
 * Its a per device decision if a telephony snap should be
   installed or not.
 * There are different components we can use to bring
   telephony into the game and we still haven't decided
   which horse we will ride for snappy (ofono, ModemManager)
 * This MP isn't aiming for feature completeness. Its just
   bringing the basic work from 15.04 to series 16 and
   leaving stuff out we don't know if we want it or not.

Also I left ofono in place as I simply copied the configflags from the debian packaging which have ofono enabled by default. That is again sth which needs to be reworked in follow up stories after we have decided where our way goes to.

For 4: I added that patch simply because all the wonderful patches we did on top of upstream doesn't build with -Werror (deprecated glib functions, ignoring const, unused variables) which is the default on xenial. I am sure you fixed some or most of them already with your 1.2 work and lets not bother with this patch too much. Its just there to get stuff building for the time being but the right way is to rework all those patches.

For 5: That icon is what we had in 15.04 for the network-manager snap. Its a more colorful networking one coming from the default icon set on desktop??

For 6: None yet. But the best would be if we get rid of them by telling the build not to install things into arch specific directories as that doesn't make much sense with snappy. Its currently a bit of a mess how those things are handled within the snap configuration but that is up for later.

For 7: Works as it should. Just the dbus conf file copying is now broken the same way as its broken for bluez.

For 8: Its in the apps list or where do you miss it?

For 9, 10: We're using both in 15.04 too right now so just bringing forward what we already had in 15.04. Something we can rework and decide on next.

For 11: Yes, I tested it and it worked back in 15.04. Didn't gave it another try yet with series 16 but if the security stuff wouldn't have broken things again it would still work as before.

For 12: As stated before: There are a number of things we can't say yet if they apply or not. We don't know much about snappy specific use cases for this snap. And my goal is still to brings stuff as closely together as possible. If there are things which don't apply to a particular platform we either don't apply the patch for that by using another series file or we hide it behind a configure option.

Overall we shouldn't be shy but bring all things together. There might be a lot things we can rule out or solve differently. I don't say we should have just one repository for everything in the beginning but that should be our goal to reach, it will have positive effects for all platforms if we do it right. We can still gate touch/desktop/snappy with separate landing branches but we should develop the whole thing with convergence in mind rather fragmenting it just more.