Merge lp://qastaging/~mpontillo/maas/migrate-dns-settings-1.8 into lp://qastaging/maas/1.8

Proposed by Mike Pontillo
Status: Merged
Approved by: Mike Pontillo
Approved revision: no longer in the source branch.
Merged at revision: 4018
Proposed branch: lp://qastaging/~mpontillo/maas/migrate-dns-settings-1.8
Merge into: lp://qastaging/maas/1.8
Diff against target: 689 lines (+409/-39)
4 files modified
src/maasserver/management/commands/edit_named_options.py (+116/-14)
src/maasserver/tests/test_commands_edit_named_options.py (+169/-15)
src/maasserver/utils/isc.py (+25/-4)
src/maasserver/utils/tests/test_isc.py (+99/-6)
To merge this branch: bzr merge lp://qastaging/~mpontillo/maas/migrate-dns-settings-1.8
Reviewer Review Type Date Requested Status
Mike Pontillo (community) Approve
Andres Rodriguez (community) Approve
Review via email: mp+264086@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-07-08.

Commit message

Backport DNS migration fixes (Merge revision 4077 from trunk)

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm! After a quick look!

review: Approve
Revision history for this message
Mike Pontillo (mpontillo) wrote :

I'll add my own +1; this was a trivial merge from trunk.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: